lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3405) maven artifacts should be equivalent to binary packaging
Date Wed, 25 Apr 2012 14:32:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261673#comment-13261673
] 

Steven Rowe commented on SOLR-3405:
-----------------------------------

bq. I think the maven artifacts should not be built from the source tree, they should instead
be built from the binary release (e.g. unzipping the .zip + augmenting with poms).

+1, I've looked at doing this in the past but didn't see a quick way to do it.

{quote}
And in the idea above, obviously -sources.jar and -javadocs.jar are "exempt", as they
are maven-specific and not in the binary packaging. Thats fine: I'm talking about
the actual binary jars. Our checking script would exclude those.

I think currently these are "the same" in the sense that
they are built from the same code, but currently have timestamp differences as they
are pulled from build/.

On the non-maven side there are improvements like this as well: for example I think
the lucene jars used by solr are "rebuilt" in the process. But i think it would be
more ideal if solr 'prepare-release', when populating the jar, populated these lucene
jars from lucene's binary release in dist/ the same way: so they are the exact same
jars that were released in the lucene binary distribution.

I dont think this stuff has to be done immediately, and i know its complicated and being
really pedantic, but I think it would be a good step.
{quote}

+1 to all of these ideas.
                
> maven artifacts should be equivalent to binary packaging
> --------------------------------------------------------
>
>                 Key: SOLR-3405
>                 URL: https://issues.apache.org/jira/browse/SOLR-3405
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Lets take the commons-csv scenario: 
> * apache-solr-3.5.0 binary distribution contains no actual commons-csv.jar anywhere,
>   in fact it contains no third party jars (the stuff present in solr/lib) at all.
> * binary distribution contains only the jars necessary for *solrj* and *contrib plugins*,
and a solr.war
> I think the maven artifacts should match whats in the binary release (no third party
jars 
> inside the .war are "exposed", we just publish the .war itself). This exposes a lot less
surface area.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message