lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4003) FieldCacheRewriteMethod.java is in tests
Date Fri, 20 Apr 2012 11:58:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258164#comment-13258164
] 

Uwe Schindler commented on LUCENE-4003:
---------------------------------------

I like this idea, too.

I would like to move this rewrite method (a little bit refactored, using FixedBitSet instead
OpenBitSet) to core, factor out the inner Filter impl to be something like MTQWrapperFilter
(maybe include the code in MTQWrapperFilter and only set a boolean in ctor). The rewrite mode
would then be similar to FilterRewrite, just with another boolean.

We can remove FieldCacheRangeFilter.newStringRange() [or at least rewrite it to use this rewrite
method], which would be elegant, too. FieldCacheTermsFilter and also the TermsFilter in contrib
can go away and we should instead use the sorted terms automaton (I always forget the name,
Dawid, sorry) as a new AtomatonQuery subclass.
                
> FieldCacheRewriteMethod.java is in tests
> ----------------------------------------
>
>                 Key: LUCENE-4003
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4003
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: selckin
>
> I believe FieldCacheRewriteMethod was accidentally moved to the wrong place in r1158697
and should be src/main and not in src/test.
> Or is it something that you don't want people to use?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message