lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3997) join module should not depend on grouping module
Date Wed, 18 Apr 2012 20:40:41 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256931#comment-13256931
] 

Martijn van Groningen commented on LUCENE-3997:
-----------------------------------------------

I also think we can move these classes to core. These are small classes and we can mark these
classes as experimental.   

Maybe we can even make this classes 'lighter' by only moving the public methods to core (maybe
as interface?). E.g. ValueSource would have all the public methods in core and a BaseValueSource
(Or AbstractValueSource) in the queries module that contains ValueSourceComparatorSource and
ValueSourceComparator. Just an idea.

I'll create a new issue to not make grouping module depend on the queries module.
                
> join module should not depend on grouping module
> ------------------------------------------------
>
>                 Key: LUCENE-3997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3997
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core? 
> Both grouping and join modules use these trivial classes, but join depends on grouping
just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name. 
> Anyway I think the change is pretty clean: its similar to having basic stuff like Analyzer.java
in core,
> so other things can work with Analyzer without depending on any specific implementing
modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message