lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3405) maven artifacts should be equivalent to binary packaging
Date Tue, 24 Apr 2012 21:04:07 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261012#comment-13261012
] 

Steven Rowe commented on SOLR-3405:
-----------------------------------

{quote}
If noggit is out there on central, then the fix will be a trivial adjustment to the template
pom. If it's not, then my suggestion for a relatively painless solution is 

1) to add a CSV file to the top of the tree, where each line consists of:

URL,GROUP-ID-INVENTED,ARTIFACT-ID-INVENTED,VERSION

2) To add each one as a dependency to the corresponding pom with <optional>true</optional>

3) implement code in the 'ant get-maven-poms' target to download them and run maven install:install-file
on them using the information in the CSV.
{quote}

Benson, the Maven build used to be able to deal with "non-Mavenized" 3rd party jars, using
a mechanism like you suggest (except that it pulled jars, & optionally POMs, from the
local file system instead of from a URL).  That capability was removed in preparation for
the 3.6 release.  

You can see what it used to look like [in r1298247 of the Lucene/Solr grandfather POM|http://svn.apache.org/viewvc/lucene/dev/trunk/dev-tools/maven/pom.xml.template?revision=1298192&view=markup#l601]
- it was a profile that listed all of the necessary jars to pull from {{lib/}} directories
and put into the local maven repository.  Users were instructed to invoke it prior to using
the Maven build: {{mvn -N -Pbootstrap install}}.

Fixing this aspect would simply require putting that stuff back for non-Mavenized jars.  This
is how the Maven build worked before the era of Fake Maven Releases of Other People's Software
(FMROOPS).

                
> maven artifacts should be equivalent to binary packaging
> --------------------------------------------------------
>
>                 Key: SOLR-3405
>                 URL: https://issues.apache.org/jira/browse/SOLR-3405
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Lets take the commons-csv scenario: 
> * apache-solr-3.5.0 binary distribution contains no actual commons-csv.jar anywhere,
>   in fact it contains no third party jars (the stuff present in solr/lib) at all.
> * binary distribution contains only the jars necessary for *solrj* and *contrib plugins*,
and a solr.war
> I think the maven artifacts should match whats in the binary release (no third party
jars 
> inside the .war are "exposed", we just publish the .war itself). This exposes a lot less
surface area.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message