lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benson Margulies (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (SOLR-3405) maven artifacts should be equivalent to binary packaging
Date Tue, 24 Apr 2012 19:45:36 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260879#comment-13260879
] 

Benson Margulies edited comment on SOLR-3405 at 4/24/12 7:44 PM:
-----------------------------------------------------------------

Wait, who said "putting your war application in maven means we must expose it as if it were
an API and take responsibility"? It's not true. It might be a default behavior of the maven-war-plugin
in simple cases, but that's different.

Anyway, to answer the previous question, no, of course I can't do that with the binary package.


The issue here should *not* be the war file. If there's an issue, it's the dependency tree
of solr-core as an ordinary dependency, and whether we want it to list (a) ordinary released
versions of third party stuff, (b) patched versions of third party stuff, or (c) no versions
of third party stuff. If you want (c), then <optional>true</optional> makes sense
to me, as it allows Steve's maven build to work and leaves the dependency management for these
things to the end user. Inconvenient but safe.

                
      was (Author: bmargulies):
    Wait, who said "putting your war application in maven means we must expose it as if it
were an API and take responsibility"? It's not true. It might be a default behavior of the
maven-war-plugin in simple cases, but that's different.

Anyway, to answer the previous question, no, of course I can't do that with the binary package.

                  
> maven artifacts should be equivalent to binary packaging
> --------------------------------------------------------
>
>                 Key: SOLR-3405
>                 URL: https://issues.apache.org/jira/browse/SOLR-3405
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Lets take the commons-csv scenario: 
> * apache-solr-3.5.0 binary distribution contains no actual commons-csv.jar anywhere,
>   in fact it contains no third party jars (the stuff present in solr/lib) at all.
> * binary distribution contains only the jars necessary for *solrj* and *contrib plugins*,
and a solr.war
> I think the maven artifacts should match whats in the binary release (no third party
jars 
> inside the .war are "exposed", we just publish the .war itself). This exposes a lot less
surface area.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message