lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3998) facet module should have no dependencies, consolidate examples into demo/
Date Wed, 18 Apr 2012 14:53:53 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3998:
--------------------------------

    Attachment: LUCENE-3998.patch

here's an initial patch (all tests pass), but there are things i don't like: see the comments
in the script (which you must run first, before applying the patch):

{noformat}
mkdir -p lucene/demo/src/java/org/apache/lucene/facet
svn add lucene/demo/src/java/org/apache/lucene/facet
svn mv lucene/facet/src/examples/org/apache/lucene/facet/example lucene/demo/src/java/org/apache/lucene/facet
svn delete lucene/facet/src/examples
mkdir -p lucene/demo/src/test/org/apache/lucene/facet
svn add lucene/demo/src/test/org/apache/lucene/facet
svn mv lucene/facet/src/test/org/apache/lucene/facet/example lucene/demo/src/test/org/apache/lucene/facet

# move to test-framework
svn move lucene/facet/src/test/org/apache/lucene/util/SlowRAMDirectory.java lucene/test-framework/src/java/org/apache/lucene/util

# nocommit: can we improve this? some facet tests testing real functionality, but 
# using example stuff... if the tests arent actually testing the example they should stay
in facet/
# and we won't need to bogusly code-dup the FacetTestUtils?
svn copy lucene/facet/src/test/org/apache/lucene/facet/FacetTestUtils.java lucene/demo/src/test/org/apache/lucene/facet
svn move lucene/facet/src/test/org/apache/lucene/facet/enhancements/EnhancementsPayloadIteratorTest.java
lucene/demo/src/test/org/apache/lucene/facet/example
svn move lucene/facet/src/test/org/apache/lucene/facet/search/TestTotalFacetCounts.java lucene/demo/src/test/org/apache/lucene/facet/example
svn move lucene/facet/src/test/org/apache/lucene/facet/search/TestTotalFacetCountsCache.java
lucene/demo/src/test/org/apache/lucene/facet/example
svn move lucene/facet/src/test/org/apache/lucene/facet/index/FacetsPayloadProcessorProviderTest.java
lucene/demo/src/test/org/apache/lucene/facet/example
{noformat}
                
> facet module should have no dependencies, consolidate examples into demo/
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-3998
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3998
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: modules/facet
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3998.patch
>
>
> currently facets depends on analyzers-common, but this is unnecessary.
> additionally it has a nice examples/ package (even with javadocs! are they actually seen
anywhere?!),
> as well as tests for those examples.
> I think instead it would be better if facet/ had no dependencies,
> and if examples+examples tests were in demo/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message