lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3998) facet module should have no dependencies, consolidate examples into demo/
Date Thu, 19 Apr 2012 04:15:16 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257214#comment-13257214
] 

Robert Muir commented on LUCENE-3998:
-------------------------------------

{quote}
So question – what's wrong with having tests depend on other modules? None of the facet/src/java
code depends on any module now, but what if facet tests would depend on demo?
{quote}

Its a sign stuff is in the wrong place.

If that stuff is really utility methods (which it looks like to me), it shouldnt be in examples
anyway.
it should be in facet/src/java as a utility method.

                
> facet module should have no dependencies, consolidate examples into demo/
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-3998
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3998
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: modules/facet
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3998.patch
>
>
> currently facets depends on analyzers-common, but this is unnecessary.
> additionally it has a nice examples/ package (even with javadocs! are they actually seen
anywhere?!),
> as well as tests for those examples.
> I think instead it would be better if facet/ had no dependencies,
> and if examples+examples tests were in demo/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message