lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3405) maven artifacts should be equivalent to binary packaging
Date Tue, 24 Apr 2012 18:49:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260814#comment-13260814
] 

Robert Muir commented on SOLR-3405:
-----------------------------------

yeah: i mean we can look at this two ways:
1) that the solr binary package is broken by just shipping solr-core.jar without its dependnecies
2) that the maven package is over-reaching by needing to specify them.

I think, more importantly than anything else (as mentioned on this issue title), that they
should match.

if its so important to use solr-core.jar (but not the war), we could add these dependencies

to the binary release too.

However we should think seriously about this: because we are talking about a lot of third
party dependencies,
a lot more to be responsible for, and trickier handling of patched dependencies. And i've
never heard
anyone complain about e.g. guava.jar not being in the binary package, ever. but maybe i'm
missing something.

I hope this makes sense: the fact that they are different I think is the worst.

                
> maven artifacts should be equivalent to binary packaging
> --------------------------------------------------------
>
>                 Key: SOLR-3405
>                 URL: https://issues.apache.org/jira/browse/SOLR-3405
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Lets take the commons-csv scenario: 
> * apache-solr-3.5.0 binary distribution contains no actual commons-csv.jar anywhere,
>   in fact it contains no third party jars (the stuff present in solr/lib) at all.
> * binary distribution contains only the jars necessary for *solrj* and *contrib plugins*,
and a solr.war
> I think the maven artifacts should match whats in the binary release (no third party
jars 
> inside the .war are "exposed", we just publish the .war itself). This exposes a lot less
surface area.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message