lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3997) join module should not depend on grouping module
Date Sun, 22 Apr 2012 12:35:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259075#comment-13259075
] 

Chris Male commented on LUCENE-3997:
------------------------------------

To me they seem to share a lot of similarities and the fact they both use the 'grouped' result
notion is an illustration of that.  

While a group could consist of Documents with any kind of relationship, that kind of a relationship
could be parent-child.  The nature of the relationship and what the result should consist
of (if its a parent-child relationship, should the 'grouped' result be parent and children,
just children or just the parent) seem to be what dictates the implementations used.  

I feel that having them as a single module would allow us to build some APIs which focus on
user land concepts and perhaps hide some of the implementation details and differences in
the joining and grouping algorithms.
                
> join module should not depend on grouping module
> ------------------------------------------------
>
>                 Key: LUCENE-3997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3997
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core? 
> Both grouping and join modules use these trivial classes, but join depends on grouping
just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name. 
> Anyway I think the change is pretty clean: its similar to having basic stuff like Analyzer.java
in core,
> so other things can work with Analyzer without depending on any specific implementing
modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message