lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sami Siren (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-899) NullPointerException in ClientUtils.writeXML on NULL field value
Date Tue, 17 Apr 2012 13:03:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255539#comment-13255539
] 

Sami Siren commented on SOLR-899:
---------------------------------

This does not seem to be a problem with trunk version of solrj: I can add fields with null
values and they are silently being ignored when the document is serialized without NPEs being
thrown.
                
> NullPointerException in ClientUtils.writeXML on NULL field value
> ----------------------------------------------------------------
>
>                 Key: SOLR-899
>                 URL: https://issues.apache.org/jira/browse/SOLR-899
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Todd Feak
>            Priority: Minor
>
> This exception occurs if I have a field in a document with a null value.
> java.lang.NullPointerException
> 	at org.apache.solr.client.solrj.util.ClientUtils.writeXML(ClientUtils.java:117)
> 	at org.apache.solr.client.solrj.request.UpdateRequest.getXML(UpdateRequest.java:169)
> 	at org.apache.solr.client.solrj.request.UpdateRequest.getContentStreams(UpdateRequest.java:160)
> ...
> Previous versions of this class had a null check, which was subsequently removed. I have
no problem with removing the previous null-check, as it seemed to "hide" a programming mistake
(i.e. null values). However, I think that the exception that occurs here could at least be
a bit more informative. Performing a null check and then throwing some sort of RuntimeException
or IOException with a descriptive message would be very helpful. Such as "Failure, NULL value
for field named[foo] detected".
> Alternatively, I think that an argument could be made that this NULL shouldn't have been
allowed in the document in the first place. If that is the case, then NULL checks with similarly
helpful messages could be performed upstream of this issue. I personally lean this way, as
I prefer to find a programming mistake closer to the source of the issue. It allows me to
find out exactly where the NULL was inserted in the first place.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message