lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-2605) CoreAdminHandler, different Output while 'defaultCoreName' is specified
Date Wed, 11 Apr 2012 03:41:35 GMT

     [ https://issues.apache.org/jira/browse/SOLR-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-2605:
---------------------------

    Attachment: SOLR-2605.patch

steffkes: your patch applies cleanly, but didn't compile -- it looks like you modified some
files that weren't included in the patch? 

based on the hoops it looked like you were having to jump through to track this, i looked
at where/how/why were were throwing away the core name if it was the default core, and took
a crack at just undo-ing that mess so that every core knows it's real and true name -- and
only the CoreContainer worries about what the name of the default core is -- this only required
two tweaks to tests (and one of those was to eliminate special hoops TestJmxIntegration was
jumping through to get the right name if the core was the default!)

Once that was done, CoreAdminHandler seemed to return consistent name info in the status for
every core, regardless of how many there were, or if a default name was in use.  So then since
i figured it would be handy, i added the defaultCoreName to the output when you get status
for all cores (either a string or null if there is no default core name) and for good measure
i also put an "isDefault" boolean in the status for each core.

try this out and see if does everything you need/want to make the UI go vroom ... like i said,
all tests pass for me, but i don't want to commit w/o some review from miller --  this fix
seems so easy i don't understand why the logic was reversed before, so i'm scared i may be
missing something
                
> CoreAdminHandler, different Output while 'defaultCoreName' is specified
> -----------------------------------------------------------------------
>
>                 Key: SOLR-2605
>                 URL: https://issues.apache.org/jira/browse/SOLR-2605
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2399-admin-cores-default.xml, SOLR-2399-admin-cores.xml, SOLR-2605.patch,
SOLR-2605.patch
>
>
> The attached XML-Files show the little difference between a defined {{defaultCoreName}}-Attribute
and a non existing one.
> Actually the new admin ui checks for an core with empty name to set single- / multicore-settings
.. it's a quick change to count the number of defined cores instead.
> But, will it be possible, to get the core-name (again)? One of both attributes would
be enough, if that makes a difference :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message