Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE5D59820 for ; Sun, 25 Mar 2012 00:34:48 +0000 (UTC) Received: (qmail 42643 invoked by uid 500); 25 Mar 2012 00:34:46 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 42576 invoked by uid 500); 25 Mar 2012 00:34:46 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 42567 invoked by uid 99); 25 Mar 2012 00:34:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Mar 2012 00:34:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Mar 2012 00:34:45 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8911D344F7F for ; Sun, 25 Mar 2012 00:34:25 +0000 (UTC) Date: Sun, 25 Mar 2012 00:34:25 +0000 (UTC) From: "Greg Bowyer (Updated) (JIRA)" To: dev@lucene.apache.org Message-ID: <589000527.13867.1332635665562.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <560389342.13848.1332635305835.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Bowyer updated SOLR-3271: ------------------------------ Attachment: SOLR-3271.patch ... Same thing, but also makes ShardHandler an interface too > ShardHandlerFactory really could be an interface > ------------------------------------------------ > > Key: SOLR-3271 > URL: https://issues.apache.org/jira/browse/SOLR-3271 > Project: Solr > Issue Type: Improvement > Affects Versions: 3.6, 4.0 > Reporter: Greg Bowyer > Priority: Trivial > Labels: distributed, shard > Attachments: SOLR-3271.patch, SOLR-3271.patch > > > While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class. > I wonder if it could just be an interface instead ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org