Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 14 Mar 2012 16:20:39 +0000 (UTC)
From: "Hoss Man (Commented) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1579272878.13388.1331742039908.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1194435734.9528.1331672921021.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-3241) Document boost fail if a field copy
 omit the norms
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/SOLR-3241?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13229=
298#comment-13229298 ]=20

Hoss Man commented on SOLR-3241:
--------------------------------

patch looks fine ... i wish there was a way to make it easier for poly fiel=
ds so they wouldn't have do do the check themselves, but when i tried the i=
dea i had it didn't work, so better to go with this for now and maybe refac=
tor a helper method later.

the few changes i would make:

1) make the new tests grab the IndexSchema obejct and assert that every fie=
ld (that the cares about) has the expected omitNorms value -- future proof =
ourselves against someone nuetering the test w/o realizing by tweaking the =
test schema because they don't know that there is a specific reason for tho=
se omitNorm settings

2) add a test that explicitly verifies the failure case of someone setting =
field boost on a field with omitNorms=3D=3Dtrue, assert that we get the exp=
ected error mesg (doesn't look like this was added when LUCENE-3796 was com=
mited, and we want to make sure we don't inadvertantly break that error che=
ck)


               =20
> Document boost fail if a field copy omit the norms
> --------------------------------------------------
>
>                 Key: SOLR-3241
>                 URL: https://issues.apache.org/jira/browse/SOLR-3241
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Tom=C3=A1s Fern=C3=A1ndez L=C3=B6bbe
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3241.patch, SOLR-3241.patch, SOLR-3241.patch, S=
OLR-3241.patch
>
>
> After https://issues.apache.org/jira/browse/LUCENE-3796, it is not possib=
le to set a boost to a field that has the "omitNorms" set to true. This is =
making Solr's document index-time boost to fail when a field that doesn't o=
mit norms is copied (with copyField) to a field that does omit them and doc=
ument boost is used. For example:
> <field name=3D"author" type=3D"text" indexed=3D"true" stored=3D"false" om=
itNorms=3D"false"/>
> <field name=3D"author_display" type=3D"string" indexed=3D"true" stored=3D=
"true" omitNorms=3D"true"/>
> <copyField source=3D"author" dest=3D"author_display"/>
> I'm attaching a possible fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org