lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: [JENKINS] Lucene-Solr-tests-only-3.x - Build # 12905 - Failure
Date Thu, 29 Mar 2012 15:53:13 GMT
On Thu, Mar 29, 2012 at 11:28 AM, Dawid Weiss
<dawid.weiss@cs.put.poznan.pl> wrote:
>> the 'help' basetokenstream gives here, that steve mentions, causes the problem.
>> I bet it catches and rethrows Throwable or something wrapped in a
>> RuntimeException?
>
> That's what it looks like.
>
>> But if its an assumptionViolatedException... it should ensure it doesnt wrap it!
>
> There should actually be a method to rethrow exceptions without
> wrapping them unnecessarily if you don't need such a wrapper. It's a
> simple trick and it does the job - I suggest that we simply use it
> (attached)?
>

maybe just for tests? like it would be ok in test-framework. I think
its a little evil to exploit type erasure this way in normal code,
confusing people by throwing checked exceptions they don't expect :)

-- 
lucidimagination.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message