lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: UpdateRequestProcessor to extract Solr XML from rich documents
Date Wed, 14 Mar 2012 16:13:40 GMT

On Mar 14, 2012, at 12:07 PM, Emmanuel Espina wrote:

> <XmlWritingUpdateProcessorFactory.java>

+1 - looks like a useful update proc. I'd make a couple minor suggestions, like looking at
the response of mkdirs and logging an error or warning if it doesn't exist and can't be made,
and closing the file writer in a finally block.

I'd go straight to a JIRA though.

- Mark Miller
lucidimagination.com












---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message