lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3778) Create a grouping convenience class
Date Wed, 07 Mar 2012 18:10:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224561#comment-13224561
] 

Michael McCandless commented on LUCENE-3778:
--------------------------------------------

Patch looks good!

bq. Also grouping by docblock and grouping features like allGroups and groupHead don't work
in a normal sharded environment (unless you partition the groups properly).

Doc block grouping should work well in a sharded env right?  As long
as you send the whole block to a single shard...

bq. This usage is very different then non distributed grouping, that is why I think it is
better to have a separate grouping convenience class for distributed grouping (DistributedGroupSearch?).

OK I agree.

{quote}
bq. Maybe you should pass the groupSort, groupsOffset, groupsLimit to the search method (instead
of setters)?

Maybe we just should have defaults for these options? Sort.RELEVANCE, 0 and 10?
{quote}

Well, I was trying to mirror IndexSearcher.search (for lack of any
other guidance on what should be required arg to ctor, optional via
setter or required arg to .search).

So, yeah, I think default to Sort.RELEVANCE is good?  Maybe we have 1
search method doing that and another taking the GroupSort?

I think it's strange to have a default for the top N groups (10)?  I
think app should have to specify that as an arg to search...

Should we name it GroupSearch?  GroupedSearch?  GroupingSearch...?  I don't
have a strong preference... I think GroupingSearch (current name) is OK?

                
> Create a grouping convenience class
> -----------------------------------
>
>                 Key: LUCENE-3778
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3778
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/grouping
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-3778.patch, LUCENE-3778.patch
>
>
> Currently the grouping module has many collector classes with a lot of different options
per class. I think it would be a good idea to have a GroupUtil (Or another name?) convenience
class. I think this could be a builder, because of the many options (sort,sortWithinGroup,groupOffset,groupCount
and more) and implementations (term/dv/function) grouping has.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message