lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3268) remove write acess to source tree (chmod 555) when running tests in jenkins
Date Mon, 26 Mar 2012 20:00:26 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238743#comment-13238743
] 

Robert Muir commented on SOLR-3268:
-----------------------------------

The ones under src/test-files is definitely problematic.
What happens is that tests put indexes in there. And later tests go
and 'update' those indexes. So if you make any change to the index format,
two things can happen (both of which have happened to me):
# you see strange exceptions and think you broke something, digging into
  tests only to find out its this src/test-files stuff.
# after committing, other developers on the mailing list get confused
  and think something is broken for the same reason.

As a temporary hack we have this in 'ant clean':

clean:
     [echo] TODO: fix tests to not write files to 'core/src/test-files/solr/data'!

But thats not a real solution.

The svn:ignore just shoves the problem under the rug.
                
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-3268
>                 URL: https://issues.apache.org/jira/browse/SOLR-3268
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.0
>
>         Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test'
and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml
(SOLR-3112), 
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that
do this will fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message