lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3778) Create a grouping convenience class
Date Sun, 11 Mar 2012 16:44:00 GMT


Robert Muir commented on LUCENE-3778:

I took a quick glance and ... completely avoiding the chaining discussion, i have a few silly
API suggestions:
* methods like enableCaching(double maxCacheRAMMB, boolean cacheScores) and enableCaching(int
maxDocsToCache, boolean cacheScores) 
  are confusing because the signature is overloaded by different primitive types... can we
give those unique names?
* methods like disableCaching(), includeScores(boolean includeScores) are a little confusing
because the verb 'set' is missing?
  In general I think getXXX and setXXX are useful, because otherwise its hard to consume the
API since you don't
  know if the method will have some unintended side effects. As an extreme example, imagine
if instead of isClosed() if you 
  used closed(), which is very different from close() but confusable.
> Create a grouping convenience class
> -----------------------------------
>                 Key: LUCENE-3778
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/grouping
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-3778.patch, LUCENE-3778.patch
> Currently the grouping module has many collector classes with a lot of different options
per class. I think it would be a good idea to have a GroupUtil (Or another name?) convenience
class. I think this could be a builder, because of the many options (sort,sortWithinGroup,groupOffset,groupCount
and more) and implementations (term/dv/function) grouping has.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message