lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3255) OpenExchangeRates.Org Exchange Rate Provider
Date Fri, 23 Mar 2012 01:22:22 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236260#comment-13236260
] 

Hoss Man commented on SOLR-3255:
--------------------------------

looks pretty cool, but that listAvailableCurrencies smells kind of fishy in general, and with
this patch smells even fishier (depending on the arg, it either returs a list of string codes,
or a list of string code perumtations with a comma separator?)

If we're seeing now, with multiple Provider impls, that the API doens't make sense -- we should
bite the bullet and change it before it's public.

perhaps two methods: listAvailableCurrencies() that returns a Set<String> and listAvailableConversions
that returns Map<String,String> ?

                
> OpenExchangeRates.Org Exchange Rate Provider
> --------------------------------------------
>
>                 Key: SOLR-3255
>                 URL: https://issues.apache.org/jira/browse/SOLR-3255
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 3.6, 4.0
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: CurrencyField
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3255.patch, SOLR-3255.patch, SOLR-3255.patch
>
>
> An exchange rate provider for CurrencyField using the freely available feed from http://openexchangerates.org/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message