lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Sokolov (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (SOLR-3204) solr-commons-csv must not use the org.apache.commons.csv package
Date Wed, 07 Mar 2012 14:28:59 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224365#comment-13224365
] 

Mike Sokolov edited comment on SOLR-3204 at 3/7/12 2:27 PM:
------------------------------------------------------------

There is no issue for users of the WAR, I think, which will generally be external to a project,
and handles all of these bundling issues internally.

The issue arises in projects that depend on the various solr jars that are bundled in its
WAR.  Using Maven, it's as if you exploded the WAR, pulled all its jars into your project,
and then added your own code too.  As an example, we've done this in a project where I work
so we can run EmbeddedSolrServer in our tests. I have it on my TODO list to break this dependency
though since it's overkill to include all of solr in our project for this convenience.  
                
      was (Author: sokolov):
    ' Short of removing Solr from Maven, is
there some way to publish Solr's WAR through Maven while keeping (some
of?) its dependencies private?

There is no issue for users of the WAR, I think, which will generally be external to a project,
and handles all of these bundling issues internally.

The issue arises in projects that depend on the various solr jars that are bundled in its
WAR.  Using Maven, it's as if you exploded the WAR, pulled all its jars into your project,
and then added your own code too.  As an example, we've done this in a project where I work
so we can run EmbeddedSolrServer in our tests. I have it on my TODO list to break this dependency
though since it's overkill to include all of solr in our project for this convenience.  
                  
> solr-commons-csv must not use the org.apache.commons.csv package
> ----------------------------------------------------------------
>
>                 Key: SOLR-3204
>                 URL: https://issues.apache.org/jira/browse/SOLR-3204
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 3.5
>            Reporter: Emmanuel Bourg
>            Priority: Blocker
>             Fix For: 3.6
>
>         Attachments: SOLR-3204.patch, solr-csv.patch
>
>
> The solr-commons-csv artifact reused the code from the Apache Commons CSV project but
the package wasn't changed to something else than org.apache.commons.csv in the process. This
creates a compatibility issue as the Apache Commons team works toward an official release
of Commons CSV. It prevents Commons CSV from using its own org.apache.commons.csv package,
or forces the renaming of all the classes to avoid a classpath conflict.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message