lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (Updated) (JIRA)" <>
Subject [jira] [Updated] (LUCENE-3821) SloppyPhraseScorer sometimes misses documents that ExactPhraseScorer finds.
Date Sun, 04 Mar 2012 07:21:57 GMT


Doron Cohen updated LUCENE-3821:

    Attachment: LUCENE-3821.patch

bq. Hmm patch has this: ... import backport.api...

Oops, here's a fixed patch, also added some comments, and removed the @Ignore from the test

bq. I'm going to be ecstatic if that crazy test finds bugs both in exact and sloppy phrase
scorers :)

It is a great test! Interestingly one thing it exposed is the dependency of the SloppyPhraseScorer
in the order of PPs in PhraseScorer when phraseFreq() is invoked. The way things work in the
super class, that order depends on the content of previously processed documents. This fix
removes that wrong dependency, of course. The point is that deliberately devising a test that
exposes such a bug seems almost impossible: first you need to think about such a case, and
if you did, writing a test that would create this specific scenario is buggy by itself. Praise
to random testing, and this random test in particular.
> SloppyPhraseScorer sometimes misses documents that ExactPhraseScorer finds.
> ---------------------------------------------------------------------------
>                 Key: LUCENE-3821
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>            Reporter: Naomi Dushay
>            Assignee: Doron Cohen
>         Attachments: LUCENE-3821.patch, LUCENE-3821.patch, LUCENE-3821_test.patch, schema.xml,
> The general bug is a case where a phrase with no slop is found,
> but if you add slop its not.
> I committed a test today (TestSloppyPhraseQuery2) that actually triggers this case,
> jenkins just hasn't had enough time to chew on it.
> ant test -Dtestcase=TestSloppyPhraseQuery2 -Dtests.iter=100 is enough to make it fail
on trunk or 3.x

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message