lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenca Petr (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3011) DIH MultiThreaded bug
Date Fri, 02 Mar 2012 09:45:59 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wenca Petr updated SOLR-3011:
-----------------------------

    Attachment: patch-3011-EntityProcessorBase-iterator.patch

Well, I solved it. The problem was in EntityProcessorBase.getNext() method which set the rowIterator
to null when it reached the end of data. Then the next thread called nextRow() on the SqlEntityProcessor
instance where the code is:
{code:title=SqlEntityProcessor.nextRow()|borderStyle=solid}
if (rowIterator == null) {
    String q = getQuery();
    initQuery(context.replaceTokens(q));
}
{/code}
So it reinitialized the query and created new row iterator from the beginning.

I am attaching a simple patch.

                
> DIH MultiThreaded bug
> ---------------------
>
>                 Key: SOLR-3011
>                 URL: https://issues.apache.org/jira/browse/SOLR-3011
>             Project: Solr
>          Issue Type: Sub-task
>          Components: contrib - DataImportHandler
>    Affects Versions: 3.5, 4.0
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3011.patch, SOLR-3011.patch, patch-3011-EntityProcessorBase-iterator.patch
>
>
> current DIH design is not thread safe. see last comments at SOLR-2382 and SOLR-2947.
I'm going to provide the patch makes DIH core threadsafe. Mostly it's a SOLR-2947 patch from
28th Dec. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message