lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (Commented) (JIRA)" <>
Subject [jira] [Commented] (SOLR-435) QParser must validate existance/absense of "q" parameter
Date Sat, 24 Mar 2012 03:41:39 GMT


Chris Male commented on SOLR-435:

Chris, as both Hoss and I said, QueryComponent can't assume that the particular QParser subclass
even needs the query string at all, such as when defType=term or something. Granted that's
very unusual but still.

That's exactly what I'm saying.  The QueryComponent is making that assumption today.  It retrieves
a query string from the 'q' param and passes it to the QParser.  Why not let the QParser do
this all itself? that way, if the QParser doesn't need a query string or gets it from somewhere
else, it can choose what to do or what not to do.
> QParser must validate existance/absense of "q" parameter
> --------------------------------------------------------
>                 Key: SOLR-435
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 3.6, 4.0
>         Attachments: SOLR-435_q_defaults_to_all-docs.patch
> Each QParser should check if "q" exists or not.  For some it will be required others
> currently it throws a null pointer:
> {code}
> java.lang.NullPointerException
> 	at org.apache.solr.common.util.StrUtils.splitSmart(
> 	at
> 	at
> 	at org.apache.solr.handler.component.QueryComponent.prepare(
> 	at org.apache.solr.handler.SearchHandler.handleRequestBody(
>         ...
> {code}
> see:

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message