lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Morrison (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3218) Range faceting support for CurrencyField
Date Thu, 08 Mar 2012 22:47:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225627#comment-13225627
] 

Andrew Morrison commented on SOLR-3218:
---------------------------------------

Hoss,

The attached patch (SOLR-3218-1.patch) adds additional tests for EUR and GBP.

I believe start/end currency equality is enforced by MoneyType.compareTo which will throw
an exception when end is compared to the first (start+gap).

As far as enforcing currency equality being a good idea or not, it would make sense and I
would prefer if start/end/gap currencies didn't need to be equal. This patch doesn't allow
for that given the tradeoff of the utility of being able to use different currencies versus
the annoyance of keeping a handle open to an ExchangeRateProvider in the places we'd need
it.

I'd be happy to take a look at making different currencies possible if there is enough interest.

It'll be good to add a test for start/end currency mismatches. I'll upload SOLR-3218-2.patch
in a moment.

                
> Range faceting support for CurrencyField
> ----------------------------------------
>
>                 Key: SOLR-3218
>                 URL: https://issues.apache.org/jira/browse/SOLR-3218
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Jan H√łydahl
>             Fix For: 4.0
>
>         Attachments: SOLR-3218-1.patch, SOLR-3218-2.patch
>
>
> Spinoff from SOLR-2202. Need to add range faceting capabilities for CurrencyField

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message