lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3859) nuke/clean up AtomicReader.hasNorms
Date Sun, 11 Mar 2012 15:17:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227066#comment-13227066
] 

Robert Muir commented on LUCENE-3859:
-------------------------------------

One thing about this patch: it removes the method but I am scared to backport the deprecation,
because I'm not sure 3.x fieldinfos really "knows" this.

So I think a good solution is to have a deprecated hasNorms sugar method in AtomicReader that
is final,
and sugar for fieldinfo.hasNorms(). This way we avoid a hard break, we can just remove this
for the 
next major release.
                
> nuke/clean up AtomicReader.hasNorms
> -----------------------------------
>
>                 Key: LUCENE-3859
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3859
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3859.patch, LUCENE-3859.patch
>
>
> implementations already have to return fieldInfos() [which can tell you this], and normValues()
[which can also tell you this].
> So if we want to keep it, I think it should just have a final implementation and not
be required for FilterReaders, etc.
> Or we can just nuke it... do we really need 3 ways to do the same thing?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message