lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2724) Deprecate defaultSearchField and defaultOperator defined in schema.xml
Date Fri, 23 Mar 2012 18:25:29 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236884#comment-13236884
] 

Erick Erickson commented on SOLR-2724:
--------------------------------------

deprecate in 3x OK. Remove from 3x examples very much NOT OK. Add a note in the 3.x schema
that this is no longer preferred, sure. But leave it in.

Remove them from trunk schema.xml OK. Remove support from 4x NOT OK. Our policy is generally
to be back-compat through one major release. This isn't quite breaking things but close enough
IMO.

My reasoning is that there are lots of people running with pre 3.6 Solr. If I were them, I
would be pretty annoyed if I got a point release, moved my <fieldType> and <field>
and <copyField> definitions over to a new example schema, started up my system and had
it behave differently because the <defaultField> was quietly removed.

This is one of those issues that, while it may well be technically preferred, making this
change is making decisions that affect running systems to no benefit of people _already_ running
those systems. "First do no harm" comes to mind.

Yes, all my objections can be met with "but all they have to do is make sure that they put
<defaultField> back". But that's not the point. We shouldn't make gratuitous changes
that make life harder for people trying to upgrade a point release.

Going to trunk is another matter, it will require a significant effort (reindexing comes to
mind) and users will approach that with much more care than 3.5 -> 3.6.

FWIW
Erick
                
> Deprecate defaultSearchField and defaultOperator defined in schema.xml
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2724
>                 URL: https://issues.apache.org/jira/browse/SOLR-2724
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis, search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I've always been surprised to see the <defaultSearchField> element and <solrQueryParser
defaultOperator="OR"/> defined in the schema.xml file since the first time I saw them.
 They just seem out of place to me since they are more query parser related than schema related.
But not only are they misplaced, I feel they shouldn't exist. For query parsers, we already
have a "df" parameter that works just fine, and explicit field references. And the default
lucene query operator should stay at OR -- if a particular query wants different behavior
then use q.op or simply use "OR".
> <similarity> Seems like something better placed in solrconfig.xml than in the schema.

> In my opinion, defaultSearchField and defaultOperator configuration elements should be
deprecated in Solr 3.x and removed in Solr 4.  And <similarity> should move to solrconfig.xml.
I am willing to do it, provided there is consensus on it of course.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message