lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3767) Explore streaming Viterbi search in Kuromoji
Date Wed, 07 Mar 2012 17:54:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224551#comment-13224551
] 

Michael McCandless commented on LUCENE-3767:
--------------------------------------------

bq. I haven't backported the test for PositionLengthAttribute since the structure seems very
different in branch_3x. Perhaps this is something we could look to as we start using PositionLength
in more of the other analyzers?

Hmm you mean TestSimpleAttributeImpl?  I think that's fine.  We'll
improve testing of pos length as we make more tokenizers/filters
graphs...

bq. Does the svn:mergeinfo look okay in the patch?

Hmm looks spooky... there was a trick for this... (and I know it's
hard to merge back since the path changed in trunk).  Maybe do svn
propdel svn:mergeinfo on all affected files, and then at the top level
you can just do an "svn merge --record-only" to update toplevel
mergeinfo?

bq. There will be some minor discrepancies between trunk and branch_3x with regards to Set<?>
and CharArraySet types. Perhaps we should use CharArraySet on across the board here in the
future?

This was from LUCENE-3765; I think it's OK to require
CharArraySet to Kuromoji...

Looks like the added files are not included in the patch (eg
RollingCharBuffer)... if you're using svn >= 1.7, you can run "svn
diff --show-copies-as-adds" maybe?  Or, use
dev-tools/scripts/diffSources.py... but I don't think it's
really necessary before committing...

Otherwise patch looks great!

                
> Explore streaming Viterbi search in Kuromoji
> --------------------------------------------
>
>                 Key: LUCENE-3767
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3767
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Michael McCandless
>            Assignee: Christian Moen
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3767.patch, LUCENE-3767.patch, LUCENE-3767.patch, LUCENE-3767.patch,
LUCENE-3767.patch, LUCENE-3767_branch_3x.patch, SolrXml-5498.xml, compound_diffs.txt
>
>
> I've been playing with the idea of changing the Kuromoji viterbi
> search to be 2 passes (intersect, backtrace) instead of 4 passes
> (break into sentences, intersect, score, backtrace)... this is very
> much a work in progress, so I'm just getting my current state up.
> It's got tons of nocommits, doesn't properly handle the user dict nor
> extended modes yet, etc.
> One thing I'm playing with is to add a double backtrace for the long
> compound tokens, ie, instead of penalizing these tokens so that
> shorter tokens are picked, leave the scores unchanged but on backtrace
> take that penalty and use it as a threshold for a 2nd best
> segmentation...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message