lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3862) DocValues getInt() returns long, getFloat() returns double
Date Sun, 11 Mar 2012 18:42:37 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227193#comment-13227193
] 

Simon Willnauer commented on LUCENE-3862:
-----------------------------------------

I should have been more specific. The reason why I did it that way is that you always have
to explicitly downcast if you are sure you are not loosing any precision. If you offer a getShort
somebody could accidentally downcast its 64 bit values into a 16 bit values without realizing.
However, if it allows us to make similarities generic we need to rething that maybe. 

I kind of like the semantics we have right now ie. you get full 64 bit values no matter what
you have encoded.

 
                
> DocValues getInt() returns long, getFloat() returns double
> ----------------------------------------------------------
>
>                 Key: LUCENE-3862
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3862
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> I think this is a bit confusing: especially for the case of something like norms
> where its really an 8 bit byte, a long is confusing.
> i think we should have the usual getFloat/getDouble/getInt/getShort/getByte instead?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message