lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Bell (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2393) Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
Date Tue, 20 Mar 2012 03:33:50 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233165#comment-13233165
] 

Bill Bell commented on SOLR-2393:
---------------------------------

Can someone please review my patch to see if it makes sense... ?

I am not an expert at these Phonetic filters. I think I nailed it, and it appears to work
well.

                
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-2393
>                 URL: https://issues.apache.org/jira/browse/SOLR-2393
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>         Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan H√łydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message