lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3859) nuke/clean up AtomicReader.hasNorms
Date Sat, 10 Mar 2012 14:46:58 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3859:
--------------------------------

    Attachment: LUCENE-3859.patch

Updated patch: same approach as before, except with some related cleanups.

FieldInfos are now public from IndexReader in 4.0, but javadoc is sparse and some naming is
inconsistent.

Patch renames FieldInfos.anyDocValuesFields() to FieldInfos.hasDocValues(), consistent with
hasProx(), hasNorms(), and hasFreq().

Patch also renames FieldInfo.normsPresent() to FieldInfo.hasNorms(), consistent with hasDocValues(),
and consistent with the naming in FieldInfoS.

Also i added some additional javadoc.
                
> nuke/clean up AtomicReader.hasNorms
> -----------------------------------
>
>                 Key: LUCENE-3859
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3859
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3859.patch, LUCENE-3859.patch
>
>
> implementations already have to return fieldInfos() [which can tell you this], and normValues()
[which can also tell you this].
> So if we want to keep it, I think it should just have a final implementation and not
be required for FilterReaders, etc.
> Or we can just nuke it... do we really need 3 ways to do the same thing?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message