lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3795) Replace spatial contrib module with LSP's spatial-lucene module
Date Fri, 02 Mar 2012 10:06:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220811#comment-13220811
] 

Robert Muir commented on LUCENE-3795:
-------------------------------------

Can we rethink this structure? In my opinion there is a little bit of dll-hell going on on.

>From Lucene's perspective as a library, 3rd party dependencies are *extremely expensive*.
I realize
this doesnt matter so much for solr, since its an app, but I think we should minimize this.

We all agreed modules should be treated like lucene core (which has no dependencies), and
sure,
some modules do have dependencies but they should be minimal and necessary.

Just looking at the lib/ directory in the branch I see:
* commons-lang.jar: This is unnecessary and only used for EqualsBuilder/HashCodeBuilder, please
remove!
* slf4j.jar: Lucene doesnt do logging: there have been numerous discussions about this, such
logging should be at a higher level app like solr. But, this doesnt seem to be 'actually'
used anyway... please remove!
* spatial4j.jar: I think this approach should be re-thought. I dont understand the advantage
of creating the extra level of indirection to a github project here. I also have no clue what
dependencies this jar itself has... furthermore i dont even know how to get the source code
for this binary jar, there is only a github link with no branches or tags to indicate "0.1".
I think all of this is a big no-go. 

                
> Replace spatial contrib module with LSP's spatial-lucene module
> ---------------------------------------------------------------
>
>                 Key: LUCENE-3795
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3795
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>
> I propose that Lucene's spatial contrib module be replaced with the spatial-lucene module
within Lucene Spatial Playground (LSP).  LSP has been in development for approximately 1 year
by David Smiley, Ryan McKinley, and Chris Male and we feel it is ready.  LSP is here: http://code.google.com/p/lucene-spatial-playground/
 and the spatial-lucene module is intuitively in svn/trunk/spatial-lucene/.
> I'll add more comments to prevent the issue description from being too long.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message