lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (SOLR-435) QParser must validate existance/absense of "q" parameter
Date Mon, 26 Mar 2012 20:42:33 GMT

    [ https://issues.apache.org/jira/browse/SOLR-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238795#comment-13238795
] 

David Smiley edited comment on SOLR-435 at 3/26/12 8:40 PM:
------------------------------------------------------------

If match none were the default, then this would be an additional difference from a filter
query aside from scoring implications.  Think about it.  If you don't add any filter queries,
in effect there is no filtering, which is kinda like the default being \*:\* even though it
strictly speaking doesn't work that way.  Shouldn't 'q' work similarly?

I'll commit a better error message later tonight:
{code}
    if (qstr == null || qstr.length() == 0)
        throw new ParseException("missing query string");
{code}
inside LuceneQParserPlugin.parse().  This is the same error message dismax & edismax use.

v3.6 is soon and I don't feel like fighting this issue once the error message is improved.
                
      was (Author: dsmiley):
    If match none were the default, then this would be an additional difference from a filter
query aside from scoring implications.  Think about it.  If you don't add any filter queries,
in effect there is no filtering, which is kinda like the default being *:* even though it
strictly speaking doesn't work that way.  Shouldn't 'q' work similarly?

I'll commit a better error message later tonight:
{code}
    if (qstr == null || qstr.length() == 0)
        throw new ParseException("missing query string");
{code}
inside LuceneQParserPlugin.parse().  This is the same error message dismax & edismax use.

v3.6 is soon and I don't feel like fighting this issue once the error message is improved.
                  
> QParser must validate existance/absense of "q" parameter
> --------------------------------------------------------
>
>                 Key: SOLR-435
>                 URL: https://issues.apache.org/jira/browse/SOLR-435
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-435_q_defaults_to_all-docs.patch
>
>
> Each QParser should check if "q" exists or not.  For some it will be required others
not.
> currently it throws a null pointer:
> {code}
> java.lang.NullPointerException
> 	at org.apache.solr.common.util.StrUtils.splitSmart(StrUtils.java:36)
> 	at org.apache.solr.search.OldLuceneQParser.parse(LuceneQParserPlugin.java:104)
> 	at org.apache.solr.search.QParser.getQuery(QParser.java:80)
> 	at org.apache.solr.handler.component.QueryComponent.prepare(QueryComponent.java:67)
> 	at org.apache.solr.handler.SearchHandler.handleRequestBody(SearchHandler.java:150)
>         ...
> {code}
> see:
> http://www.nabble.com/query-parsing-error-to14124285.html#a14140108

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message