lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (LUCENE-3853) Improve MIGRATE.txt for FieldsEnum/TermsEnum
Date Tue, 06 Mar 2012 15:13:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223314#comment-13223314
] 

Uwe Schindler edited comment on LUCENE-3853 at 3/6/12 3:13 PM:
---------------------------------------------------------------

Nice!

some comments:
- "If you pass a SegmentReader to SlowCompositeReaderWrapper  it will simply return reader.fields(),"
should be "If you pass a SegmentReader to SlowCompositeReaderWrapper.wrap() it will simply
return itsself,"
- The MultiFields comment should be in the line of @lucene.internal (changed from @lucene.experimental).
@lucene.internal will already print the "internal" warning. We should review the other Multi*
classes, too. They are all internal not experimental.
                
      was (Author: thetaphi):
    Nice!

some comments:
- "If you pass a SegmentReader to SlowCompositeReaderWrapper  it will simply return reader.fields(),"
should be "If you pass a SegmentReader to SlowCompositeReaderWrapper.wrap() it will simply
return itsself)"
- The MultiFields comment should be in the line of @lucene.internal (changed from @lucene.experimental).
@lucene.internal will already print the "internal" warning. We should review the other Multi*
classes, too. They are all internal not experimental.
                  
> Improve MIGRATE.txt for FieldsEnum/TermsEnum
> --------------------------------------------
>
>                 Key: LUCENE-3853
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3853
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 4.0
>            Reporter: Benson Margulies
>         Attachments: LUCENE-3853.patch, LUCENE-3853.patch, LUCENE-3853.patch
>
>
> The text in MIGRATE.txt that explains the new situation with FieldsEnum seems to be missing
a level of object in explaining TermEnum. Perhaps it didn't keep with the code. here's a patch
to MIGRATE.txt.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message