lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3276) Fix attribute conventions for JapaneseTokenizerFactory and add important information to schema.xml
Date Wed, 28 Mar 2012 13:46:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240409#comment-13240409
] 

Robert Muir commented on SOLR-3276:
-----------------------------------

I'll review your patch when its ready, but conceptually I don't see any issue with this.

I don't have any issue at all with documentation, test, or bug fixes. We shouldn't be
adding any new features at this point though.

Just mark any issues you find like this as blocker and give extra time to review since we
are in freeze.

Its definitely helpful to be finding and fixing this stuff *before* the release candidate
because it saves us all time.

Thanks!
                
> Fix attribute conventions for JapaneseTokenizerFactory and add important information
to schema.xml
> --------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3276
>                 URL: https://issues.apache.org/jira/browse/SOLR-3276
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 3.6, 4.0
>            Reporter: Christian Moen
>            Assignee: Christian Moen
>            Priority: Blocker
>
> The description of the {{ja_text}} field type in {{schema.xml}} is incomplete, doesn't
describe user dictionaries and lacks a reference to the wiki page with extensive Japanese
language support details ([http://wiki.apache.org/solr/JapaneseLanguageSupport] - currently
a placeholder page).
> The attribute convention used by {{JapaneseTokenizerFactory}} doesn't comply with the
standards and used {{user-dictionary}} and {{user-dictionary-encoding}} instead of {{userDictionary}}
and {{userDictionaryEncoding}}.
> These changes are low risk and it would be a shame to not get this right in 3.6 with
all the work done on Japanese.
> Patch coming up shortly.  I really hope it's okay to commit this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message