lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Russell Black (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3196) partialResults response header not propagated in distributed search
Date Tue, 13 Mar 2012 18:38:41 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228573#comment-13228573
] 

Russell Black commented on SOLR-3196:
-------------------------------------

I'm not sure why the original patch fails to apply to 3x.  However, your patch looks good
to me.  

I don't see any problems with backwards compatibility.  This patch has the effect of adding
a {{partialResults true}} header, making it behave the same as a non-distributed request for
time limited queries.  It's hard for me to imagine a situation where this would break backwards-compatibility.
                
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
>                 Key: SOLR-3196
>                 URL: https://issues.apache.org/jira/browse/SOLR-3196
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 3.5, 4.0
>            Reporter: Russell Black
>              Labels: patch
>         Attachments: SOLR-3196-3x.patch, SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header
that indicates when a search was terminated early due to running out of time.  This header
is being discarded by the collator.  Patch to follow.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message