lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3268) remove write acess to source tree (chmod 555) when running tests in jenkins
Date Fri, 23 Mar 2012 10:45:27 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated SOLR-3268:
------------------------------

    Attachment: SOLR-3268_sync.patch

So I was wrong about the resource-sync idea: here's a patch implementing it.

unfortunately this is not a great solution:
* it only solves one of the problems (for some reason SOLR-3112 is not solved by this).
* its just syncing the test-files to build/test-files and putting that in classpath instead:
but this still doesnt "fix" anything, any tests that modify things in here could interfere
with other tests because its not a per-jvm sandbox like TEMP_DIR, and its definitely not per-test.

Bottom line: I think really the best solution is that tests that want to write files to their
configuration area should create a temporary directory (via our normal tempdir mechanism)
and write to that... 
                
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-3268
>                 URL: https://issues.apache.org/jira/browse/SOLR-3268
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test'
and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml
(SOLR-3112), 
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that
do this will fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message