lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2724) Deprecate defaultSearchField and defaultOperator defined in schema.xml
Date Fri, 23 Mar 2012 19:29:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236973#comment-13236973
] 

Erick Erickson commented on SOLR-2724:
--------------------------------------

David:

Well, I don't particularly want to argue indefinitely on this one, so we'll probably have
to agree to disagree. But I totally disagree with this statement:

bq: Besides, I don't think there should be any expectation of "it'll just work" if you copy
some arbitrary subset of an old schema into a new example config.

>From a user's perspective:
"I know all I changed were X, Y and Z in my schema, I'll copy those to the new one and I should
be good to go. That way I'll pick up any new goodness without having to examine every line,
including ones I haven't changed." is quite reasonable IMO. Messy, but true. We have a better
argument with a major release when we say "you should have read the CHANGES.txt file". 

My touchstone is that on a point release I think this kind of change can make our user's lives
harder to no good purpose, this change doesn't give them capabilities they don't already have
in exchange for any difficulties that result.

And I'm not saying that backwards compat on the config is required, it's not as far as I know.
It's more that I'd vastly prefer to mark this as deprecated in 3.6 and perhaps remove it in
the 4.x schema.xml, but leave in the code in 4.x so if someone does have it in their 4.0 schema
they're not surprised...

At any rate, I can live with whatever decision comes out here, but misquoting the Lorax, "I
speak for the users".


                
> Deprecate defaultSearchField and defaultOperator defined in schema.xml
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2724
>                 URL: https://issues.apache.org/jira/browse/SOLR-2724
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis, search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I've always been surprised to see the <defaultSearchField> element and <solrQueryParser
defaultOperator="OR"/> defined in the schema.xml file since the first time I saw them.
 They just seem out of place to me since they are more query parser related than schema related.
But not only are they misplaced, I feel they shouldn't exist. For query parsers, we already
have a "df" parameter that works just fine, and explicit field references. And the default
lucene query operator should stay at OR -- if a particular query wants different behavior
then use q.op or simply use "OR".
> <similarity> Seems like something better placed in solrconfig.xml than in the schema.

> In my opinion, defaultSearchField and defaultOperator configuration elements should be
deprecated in Solr 3.x and removed in Solr 4.  And <similarity> should move to solrconfig.xml.
I am willing to do it, provided there is consensus on it of course.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message