lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luca Cavanna (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
Date Fri, 23 Mar 2012 15:23:29 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Luca Cavanna updated SOLR-3112:
-------------------------------

    Attachment: SOLR-3112.patch

I noticed that TestSolrProperties and TestEmbeddedSolrServer were really similar. They both
worked on the test-files folder, but the last one cleaned everything at the end, while the
second one not.
I created a base class to avoid copy pasting the same code, then I changed both to work on
a temp directory, without modifying anything on the test-files folder.

Regarding the other elevate-data-distrib.xml problem mentioned in the SOLR-3268, I had a look
at it. It seems to copy the core/src/test-files/solr/conf/elevate.xml to same path but different
filename (elevate-data-distrib.xml) right before testing. Then the test uses the new file
and doesn't clean it at the end. Well, I wonder why the test makes that copy. Maybe I didn't
get something, but rather than cleaning at the end, my patch removes that copy and the test
seems to work anyway. Let me know if there's a better fix for this!
                
> after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is
leftover
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3112
>                 URL: https://issues.apache.org/jira/browse/SOLR-3112
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3112.patch
>
>
> This is especially confusing, as then it looks like you dont have a clean checkout.
> For now it should be under svn:ignore, but ultimately we really should not be creating
files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message