lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Khludnev (Updated) (JIRA)" <>
Subject [jira] [Updated] (SOLR-3011) DIH MultiThreaded bug
Date Fri, 16 Mar 2012 20:39:39 GMT


Mikhail Khludnev updated SOLR-3011:

    Attachment: SOLR-3011.patch

OK. next attempt. 

Core point is cover case shed by Petr: requerying a datasource. I amended MockDatasource to
use collection intead of extraditable iterators. It reveals two things: incorrect entityEnded
flag - I killed it. Also cache and entityProcessor has wrong two statelogic: non-init/init.
I implemented more correct three sate FSM: non-init, iterating, eof. Also I had to push code
from ThreadedEPW into plain EPW. AFAIK overhead from redundant synchronize is misarable. 

delta between patches for fast review

Petr, can't you check that it works. You can take the applied patch from
> DIH MultiThreaded bug
> ---------------------
>                 Key: SOLR-3011
>                 URL:
>             Project: Solr
>          Issue Type: Sub-task
>          Components: contrib - DataImportHandler
>    Affects Versions: 3.5, 4.0
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>             Fix For: 4.0
>         Attachments: SOLR-3011.patch, SOLR-3011.patch, SOLR-3011.patch, patch-3011-EntityProcessorBase-iterator.patch,
> current DIH design is not thread safe. see last comments at SOLR-2382 and SOLR-2947.
I'm going to provide the patch makes DIH core threadsafe. Mostly it's a SOLR-2947 patch from
28th Dec. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message