lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (SOLR-3204) solr-commons-csv must not use the org.apache.commons.csv package
Date Tue, 06 Mar 2012 16:01:54 GMT


Robert Muir commented on SOLR-3204:

I think the jarjar idea was raised quite often, this seems to be a good solution, so we republish
all "changed" dependencies using a different class/pkg name.

This sets an unreasonable burden to fix a simple bug in a third-party component (think, the
jetty patch).

Its already hard enough to dive in as "stranger in a strange land" to some other codebase
to fix a bug that affects our stuff,
and then to rename anything that uses it too just because of maven?

Lets take the jetty case... should we seriously rename all the jetty stuff because it has
a unicode bug? what about configuration 
and reflection and stuff for this servlet container? E.g. users will no longer be able to
use any normal jetty configuration or
jetty documentation because we re-jarjared all the package names?

<Configure id="Server" class="org.eclipse.jetty.server.Server">
  <!-- basic configuration here -->


this is insane.

> solr-commons-csv must not use the org.apache.commons.csv package
> ----------------------------------------------------------------
>                 Key: SOLR-3204
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 3.5
>            Reporter: Emmanuel Bourg
>            Priority: Blocker
>             Fix For: 3.6
>         Attachments: solr-csv.patch
> The solr-commons-csv artifact reused the code from the Apache Commons CSV project but
the package wasn't changed to something else than org.apache.commons.csv in the process. This
creates a compatibility issue as the Apache Commons team works toward an official release
of Commons CSV. It prevents Commons CSV from using its own org.apache.commons.csv package,
or forces the renaming of all the classes to avoid a classpath conflict.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message