lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3241) Document boost fail if a field copy omit the norms
Date Wed, 14 Mar 2012 03:10:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228914#comment-13228914
] 

Hoss Man commented on SOLR-3241:
--------------------------------

part of me things we should just remove the error checking for {{omitNorms && boost
!= 1.0F}} from DocumentBuilder.toDocument (added in /LUCENE-3796) and just silently ignore
any boost on a SolrInputField where omitNorms==true (ie: maybe log a warning, but don't throw
an Exception).  This would be consistent with the behavior in past releases (except for the
warning log if we add that), and wouldn't cause any confusing errors for things like LatLonType
(even if they come from third-party plugins we can't contro/test)

On the other hand... that feels really dirty, and it would be nice to fail fast and loud if
the client tries to set a boost on an omitNorms field

Perhaps a better fix would be to leave DocumentBuilder exactly as it is today, and instead
change FieldType.createField to (silently) ignore the boost if omitNorms==true for that SchemaField.
 if i'm thinking about this right, that would mean the error checking of the SolrInputDocument
(and all it's SolrInputFields) in DocumentBuilder.toDocument would still work as designed
-- so you'd get an error if any client or "high level" plugin like an UpdateProcessor tried
to use a field boost on an omitNorms field; but any fields added at a lower level (ie: by
copyField or a poly field) would silently ignore those boosts if they were copied/cloned to
a field where omitNorms==true.






                
> Document boost fail if a field copy omit the norms
> --------------------------------------------------
>
>                 Key: SOLR-3241
>                 URL: https://issues.apache.org/jira/browse/SOLR-3241
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Tomás Fernández Löbbe
>             Fix For: 4.0
>
>         Attachments: SOLR-3241.patch
>
>
> After https://issues.apache.org/jira/browse/LUCENE-3796, it is not possible to set a
boost to a field that has the "omitNorms" set to true. This is making Solr's document index-time
boost to fail when a field that doesn't omit norms is copied (with copyField) to a field that
does omit them and document boost is used. For example:
> <field name="author" type="text" indexed="true" stored="false" omitNorms="false"/>
> <field name="author_display" type="string" indexed="true" stored="true" omitNorms="true"/>
> <copyField source="author" dest="author_display"/>
> I'm attaching a possible fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message