lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (Updated) (JIRA) <j...@apache.org>
Subject [jira] [Updated] (SOLR-3093) Decide destiny of LuceneQueryOptimizer (solrconfig.xml: <boolTofilterOptimizer>)
Date Tue, 13 Mar 2012 10:09:39 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jan Høydahl updated SOLR-3093:
------------------------------

      Description: 
SolrConfig.java still tries to parse <boolTofilterOptimizer>
But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented
out since 3.1.

>From Solr3.6 we print a warning if we find this option is found in solrconfig.xml (SOLR-1052):
{noformat}
WARN: solrconfig.xml: <boolTofilterOptimizer> is currently not implemented and has no
effect.
{noformat}

However, the dead, commented code is still in place in {{SolrConfig.java, SolrIndexSearcher.Java}}.
We should decide what do do, either re-implement boolTofilterOptimizer or remove it completely.

  was:
SolrConfig.java still tries to parse <boolTofilterOptimizer>
But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented
out.

Probably the whole logic should be ripped out, and we fail hard if we find this config option
in solrconfig.xml


Also, the <HashDocSet> config option is old and no longer used or needed? There is some
code which tries to use it but I believe that since 1.4 there are more efficient ways to do
the same. Should we also fail-fast if found in config or only print a warning?

         Priority: Minor  (was: Major)
    Fix Version/s:     (was: 3.6)
         Assignee: Mark Miller  (was: Jan Høydahl)
       Issue Type: Task  (was: Improvement)
          Summary: Decide destiny of LuceneQueryOptimizer (solrconfig.xml: <boolTofilterOptimizer>)
 (was: Remove unused features <boolTofilterOptimizer> and <HashDocSet>)

Assigning to Mark, as you commented out the code way back :)
                
> Decide destiny of LuceneQueryOptimizer (solrconfig.xml: <boolTofilterOptimizer>)
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-3093
>                 URL: https://issues.apache.org/jira/browse/SOLR-3093
>             Project: Solr
>          Issue Type: Task
>            Reporter: Jan Høydahl
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.0
>
>
> SolrConfig.java still tries to parse <boolTofilterOptimizer>
> But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented
out since 3.1.
> From Solr3.6 we print a warning if we find this option is found in solrconfig.xml (SOLR-1052):
> {noformat}
> WARN: solrconfig.xml: <boolTofilterOptimizer> is currently not implemented and
has no effect.
> {noformat}
> However, the dead, commented code is still in place in {{SolrConfig.java, SolrIndexSearcher.Java}}.
We should decide what do do, either re-implement boolTofilterOptimizer or remove it completely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message