lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3836) Most Codec.*Format().*Reader() methods should use SegmentReadState
Date Thu, 01 Mar 2012 15:43:57 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220105#comment-13220105
] 

Robert Muir commented on LUCENE-3836:
-------------------------------------

{quote}
(The reason I'm doing this at the codec level is that I wanted to avoid heavy mods to SegmentReader,
and it's easier to visualize how this data is re-mapped and stacked at the level of fairly
simple codec APIs).
{quote}

But SegmentReader is fairly simple these days, its just basically a pointer to a core (SegmentCoreReaders)
+ deletes.

Maybe it should stay the same, but instead we could have a StackedReader (perhaps a bad name),
that points to multiple cores + deletes + mask files or whatever it needs and returns masked
enums over the underlying Enums itself (e.g. combining enums from the underlying impls, passing
masks down as Bits, and such). SegmentReader would stay as-is.

                
> Most Codec.*Format().*Reader() methods should use SegmentReadState
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3836
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3836
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/codecs
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 4.0
>
>         Attachments: LUCENE-3836.patch
>
>
> Codec formats API for opening readers is inconsistent - sometimes it uses SegmentReadState,
in other cases it uses individual arguments that are already available via SegmentReadState.
This complicates extending the API, e.g. if additional per-segment state would need to be
passed to the readers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message