lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-2338) Some tests catch Exceptions in separate threads and just print a stack trace - the test does not fail
Date Fri, 23 Mar 2012 21:31:25 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-2338:
----------------------------------

    Fix Version/s:     (was: 3.6)

I remove 3.x branch. I chacked all tests using e.printStackTrace() and all have some (outdated)
logic to report the failure. In trunk we should rewrite those tests to simply fail()/rethrow
as RuntimeEx on any Exception in threads. This way the failures are reported consistently.
                
> Some tests catch Exceptions in separate threads and just print a stack trace - the test
does not fail
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2338
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2338
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/build
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.0
>
>
> Some tests catch Exceptions in separate threads and just print a stack trace - the test
does not fail. The test should fail. Since LUCENE-2274, the LuceneTestCase(J4) class installs
an UncaughtExceptionHandler, so this type of catching and solely printing a Stack trace is
a bad idea. Problem is, that the run() method of threads is not allowed to throw checked Exceptions.
> Two possibilities:
> - Catch checked Exceptions in the run() method and wrap into RuntimeException or call
Assert.fail() instead
> - Use Executors

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message