lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (LUCENE-3836) Most Codec.*Format().*Reader() methods should use SegmentReadState
Date Thu, 01 Mar 2012 15:23:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220093#comment-13220093
] 

Andrzej Bialecki  edited comment on LUCENE-3836 at 3/1/12 3:22 PM:
-------------------------------------------------------------------

I think this could work, too - I would instantiate the "overlay" data in SegmentReader, and
then I'd create the "overlay" codec's format readers in SegmentReader, using the original
format readers plus the overlay data. I'll try this approach ... I'll create a separate issue
to discuss this.

(The reason I'm doing this at the codec level is that I wanted to avoid heavy mods to SegmentReader,
and it's easier to visualize how this data is re-mapped and stacked at the level of fairly
simple codec APIs).

Let's close this as won't fix for now.
                
      was (Author: ab):
    I think this could work, too - I would instantiate the "overlay" data in SegmentReader,
and then I'd create the "overlay" codec's format readers in SegmentReader, using the original
format readers plus the overlay data. I'll try this approach ... I'll create a separate issue
to discuss this.

Let's close this as won't fix for now.
                  
> Most Codec.*Format().*Reader() methods should use SegmentReadState
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3836
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3836
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/codecs
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 4.0
>
>         Attachments: LUCENE-3836.patch
>
>
> Codec formats API for opening readers is inconsistent - sometimes it uses SegmentReadState,
in other cases it uses individual arguments that are already available via SegmentReadState.
This complicates extending the API, e.g. if additional per-segment state would need to be
passed to the readers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message