lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3029) Poor json formatting of spelling collation info
Date Thu, 29 Mar 2012 15:18:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241299#comment-13241299
] 

Yonik Seeley commented on SOLR-3029:
------------------------------------

Thanks for the explanations!  (and yeah, I had lost track of the older issues...)

bq. The collations are ranked, so order is important.

I guess I meant for a single collation:
{code}
"collation",[
        "collationQuery","abcdefgx solra",
        "hits",0,
        "misspellingsAndCorrections",[...
{code}

It seems like that should be a map?
{code}
{"collationQuery" : "abcdefgx solra",
 "hits" : 0
 "misspellingsAndCorrections" : {...
}
{code}

And if there are multiple collations, there should be an array of those maps?

bq. I do agree the spellcheck response format leaves something to be desired and maybe 4.0
is a good time to break backwards and improve it.

+1, go for it!
                
> Poor json formatting of spelling collation info
> -----------------------------------------------
>
>                 Key: SOLR-3029
>                 URL: https://issues.apache.org/jira/browse/SOLR-3029
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 4.0
>            Reporter: Antony Stubbs
>            Priority: Blocker
>         Attachments: SOLR-3029.patch
>
>
> {noformat}
> "spellcheck": {
>     "suggestions": [
>     "dalllas",
>     {
> <snip>
>         {
>             "word": "canallas",
>             "freq": 1
>         }
>         ]
>     },
>     "correctlySpelled",
>     false,
>     "collation",
>     "dallas"
>     ]
> }
> {noformat}
> The correctlySpelled and collation key/values are stored as consecutive elements in an
array - quite odd. Is there a reason isn't not a key/value map like most things?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message