lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3774) check-legal isn't doing its job
Date Sat, 31 Mar 2012 14:10:28 GMT


Yonik Seeley commented on LUCENE-3774:

bq. I have a different view on this. Things like this (license checking) are typically integration
tests. Having them per-module only complicates build files and is an unnecessary overhead
for running normal tests (because dependencies change rarely).


Having been bit by the changes in this issue dozens of times already, we shouldn't be doing
these checks on a normal "ant test".  Seems like it should be fine to let Jenkins test it.

* SolrCloud demo instructions that have you make a copy of example it example2, etc.
* mv build build.old so I could compare two runs
* try out a new jar locally w/o dotting all the i's

I've seen users report these errors on the mailing list too, and it's not apparent to them
what the issue is.
> check-legal isn't doing its job
> -------------------------------
>                 Key: LUCENE-3774
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Dawid Weiss
>             Fix For: 3.6, 4.0
>         Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch,
LUCENE-3774.patch, LUCENE-3774.patch, LUCENE3774.patch, backport.patch
> In trunk, the {{check-legal-lucene}} ant target is not checking any {{lucene/contrib/\*\*/lib/}}
directories; the {{modules/**/lib/}} directories are not being checked; and {{check-legal-solr}}
can't be checking {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files
in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in which to check,
but modules move around, and these lists are not being kept up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a {{lib/}}
directory, and it should be specialized for modules that have more than one ({{solr/core/}})
or that have a {{lib/}} directory in a non-standard place ({{lucene/core/}}).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message