lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3659) Improve Javadocs of RAMDirectory to document its limitations and add improvements to make it more GC friendly on large indexes
Date Mon, 26 Mar 2012 14:56:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238448#comment-13238448
] 

Robert Muir commented on LUCENE-3659:
-------------------------------------

I think if we were to implement it this way, its not a burden on codecs.
By default, somewhere in lucene core inits the codec APIs with a context always.
For example SegmentInfos.write():
{code}
infosWriter.writeInfos(directory, segmentFileName, codec.getName(), this, IOContext.DEFAULT);
{code}

and DocFieldProcessor/SegmentMerger for fieldinfos:
{code}
infosWriter.write(state.directory, state.segmentName, state.fieldInfos, IOContext.DEFAULT);
{code}

These guys would just set this in the IOContext. Most/All codecs just pass this along.
If a codec wants to ignore the IOContext and lie about it, thats its own choice.
So I think its an easy change.

                
> Improve Javadocs of RAMDirectory to document its limitations and add improvements to
make it more GC friendly on large indexes
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3659
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3659
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 3.5, 4.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3659.patch, LUCENE-3659.patch, LUCENE-3659.patch
>
>
> Spinoff from several dev@lao issues:
> - [http://mail-archives.apache.org/mod_mbox/lucene-dev/201112.mbox/%3C001001ccbf1c%2471845830%24548d0890%24%40thetaphi.de%3E]
> - issue LUCENE-3653
> The use cases for RAMDirectory are very limited and to prevent users from using it for
e.g. loading a 50 Gigabyte index from a file on disk, we should improve the javadocs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message