Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: 
 <CANGii8f_5rMtGfSPRorogEfuP1iNZY19R2Y2iTE+d5pSXaNuzQ@mail.gmail.com>
References: 
 <CANGii8e9j870i=WA+1NKQq5BxtM_d6u+n4=HWTDCwSY++WdfZw@mail.gmail.com>
 <CAL8PwkaN9t8ZmBRPf_mkUWVT8d-aZwRxyk0ntFEo9o-DV1CP=g@mail.gmail.com>
 <CANGii8cW6B8MniES=izVjeUi+Q7ez3HBU=5LgajS1MvXx2DZew@mail.gmail.com>
 <CAL8PwkYOaq7VRXUh5tJZBSQS6V2C3AnyaUvWyTxee9RVii9WMw@mail.gmail.com>
 <CANGii8f_5rMtGfSPRorogEfuP1iNZY19R2Y2iTE+d5pSXaNuzQ@mail.gmail.com>
From: Michael McCandless <lucene@mikemccandless.com>
Date: Tue, 7 Feb 2012 10:19:08 -0500
Message-ID: 
 <CAL8Pwka_+0r4g47pJ68ckKbjpvJgapeW-LEKv4LTVTPCQAE+zA@mail.gmail.com>
Subject: Re: ToParentBlockJoinQuery vs filtered search
To: dev@lucene.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Mikhail,

I'll dig into this and post back on the issue... I think something is
indeed not right!  Thanks for raising this :)

Mike McCandless

http://blog.mikemccandless.com

On Mon, Feb 6, 2012 at 3:59 PM, Mikhail Khludnev
<mkhludnev@griddynamics.com> wrote:
>
>
> On Mon, Feb 6, 2012 at 5:54 PM, Michael McCandless
> <lucene@mikemccandless.com> wrote:
>>
>> On Sun, Feb 5, 2012 at 11:43 PM, Mikhail Khludnev
>> <mkhludnev@griddynamics.com> wrote:
>>
>> > Thanks for resolving my hesitations. It allows me move forward.
>>
>> You're welcome!
>>
>> >> It looks like that's what your test case is testing for...? =A0Does i=
t
>> >> pass?
>> >
>> > Of course it doesn't.
>> > the first reason is that BlockJoinWeight.scorer()
>> >
>> > http://svn.apache.org/viewvc/lucene/dev/trunk/modules/join/src/java/or=
g/apache/lucene/search/join/ToParentBlockJoinQuery.java?view=3Dmarkup
>> > has the opposite intention (btw, are you %100 sure?):
>> > =A0* Children query is filtered by the given filter
>> > childWeight.scorer(readerContext, true, false, *acceptDocs*);
>> > =A0* Parent filter=A0 is not constrained
>> > parentsFilter.getDocIdSet(readerContext,
>> > *readerContext.reader().getLiveDocs()*);
>> > That's why I asked for the rationale of filtered BJQ search.
>> >
>> > The also complication which I met is that
>> > AssertingIndexSearcher.wrapFilter() randomly switches from filtered
>> > search to FilteredQuery.
>> >
>> > http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test-framewor=
k/java/org/apache/lucene/search/AssertingIndexSearcher.java
>> > it leads to IllegalStateException"parentFilter must return
>> > FixedBitSet; got "BitsFilteredDocIdSet. I suppose I can deal with it.
>>
>> Hang on -- there are 2 different filters here.
>>
>> The first one, the parentsFilter that you pass to
>> ToParent/ChildBlockJoinQuery, is very specific: it must identify which
>> docs are parent docs. =A0This is unchangeable: every BJQ must use this
>> same filter, since what is parent and what is child was determined at
>> indexing time when you indexed the blocks. =A0It must produce a
>> FixedBitSet per segment (using CachingWrapperFilter does so).
>
>
> Thank you. it's clear. But you need to pass bits into
> ToParentBlockJoinQuery.BlockJoinWeight.scorer(AtomicReaderContext, boolea=
n,
> boolean, Bits){.
> ...
> final DocIdSet parents =3D parentsFilter.getDocIdSet(readerContext, accep=
tDocs
> );
>
> It can't be liveDocs or null if you want to apply the given filter (it's =
can
> also be case if you have deleted documents in the generation, and
> therefore=A0liveDocs aren't null).
> Passing non-null bits triggers wrapping bitset by bits see
> CachingWrapperFilter.getDocIdSet(AtomicReaderContext, Bits) line 136 and
> lead to=A0BitsFilteredDocIdSet.
>
> I moved to=A0https://issues.apache.org/jira/browse/SOLR-3076=A0in accordi=
ng to
> Marting suggestion. Can't you reply there, please?
>
>
>>
>>
>> The second filter, is the optional filter the outside app can pass to
>> IndexSearcher.search -- it's this filter that I was describing in my
>> last response (ie, that it will be used in the "to" document space,
>> only). =A0This filter is obviously free to change per query, depending
>> on what the app is doing...
>>
>> Mike
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
>
>
> --
> Sincerely yours
> Mikhail Khludnev
> Lucid Certified
> Apache Lucene/Solr Developer
> Grid Dynamics
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org