Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 418E0963A for ; Fri, 24 Feb 2012 21:46:46 +0000 (UTC) Received: (qmail 72569 invoked by uid 500); 24 Feb 2012 21:46:45 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 72501 invoked by uid 500); 24 Feb 2012 21:46:45 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 72494 invoked by uid 99); 24 Feb 2012 21:46:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 21:46:45 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ryantxu@gmail.com designates 209.85.214.176 as permitted sender) Received: from [209.85.214.176] (HELO mail-tul01m020-f176.google.com) (209.85.214.176) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 21:46:38 +0000 Received: by obbwd18 with SMTP id wd18so4946532obb.35 for ; Fri, 24 Feb 2012 13:46:17 -0800 (PST) Received-SPF: pass (google.com: domain of ryantxu@gmail.com designates 10.182.182.100 as permitted sender) client-ip=10.182.182.100; Authentication-Results: mr.google.com; spf=pass (google.com: domain of ryantxu@gmail.com designates 10.182.182.100 as permitted sender) smtp.mail=ryantxu@gmail.com; dkim=pass header.i=ryantxu@gmail.com Received: from mr.google.com ([10.182.182.100]) by 10.182.182.100 with SMTP id ed4mr1587963obc.24.1330119977406 (num_hops = 1); Fri, 24 Feb 2012 13:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=AekqSNgnTpQMiIVeFwLinriyR5i/PNFclTw2fPBg4rg=; b=Bj72QgEuuEEHCJ7j21hxr0cmdxZSBNcMRwy58iNRcZ9MnKY3jFLK/F7mGVurq5UAIo 3cBMLIxO56BYWfRQOy2vfNYbRdQuMuftmecHiufA4jNM2HbvFP4u+qRtPMoRilUPgfAG ueNkbogUF+o6M5HTkyrUy+uEfDleLa9AOvW2k= MIME-Version: 1.0 Received: by 10.182.182.100 with SMTP id ed4mr1363967obc.24.1330119977340; Fri, 24 Feb 2012 13:46:17 -0800 (PST) Received: by 10.182.88.2 with HTTP; Fri, 24 Feb 2012 13:46:17 -0800 (PST) In-Reply-To: References: Date: Fri, 24 Feb 2012 13:46:17 -0800 Message-ID: Subject: Re: customization for SolrRequestParsers From: Ryan McKinley To: dev@lucene.apache.org Content-Type: multipart/alternative; boundary=14dae939965dc20de704b9bcb0cb X-Virus-Checked: Checked by ClamAV on apache.org --14dae939965dc20de704b9bcb0cb Content-Type: text/plain; charset=ISO-8859-1 I don't recall exactly... but I think it was just an open suggestion that we *could* use a different parser. Since that comment was added (5 years ago?) i don't think it has come up... but if there is a good use case (and a patch) it may still be a good idea On Fri, Feb 24, 2012 at 12:03 PM, Mikhail Khludnev < mkhludnev@griddynamics.com> wrote: > Ryan, > > I did it too, but just for curious, what was the idea of "pick a different > parser based on request"? > > > On Fri, Feb 24, 2012 at 11:06 PM, Ryan McKinley wrote: > >> I don't know exactly what you are trying to do... but you *may* be able >> to do it by overriding SolrDispatchFilter#execute(...) >> >> In my app, we add authentication tokens to the request context there. >> >> >> >> On Fri, Feb 24, 2012 at 7:49 AM, Mikhail Khludnev < >> mkhludnev@griddynamics.com> wrote: >> >>> Hello, >>> >>> I see that some sort of customization was expected >>> for SolrRequestParsers. >>> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java?view=markup >>> >>> line >>> 97 // I don't see a need to have this publicly configured just yet >>> and >>> 111 // TODO -- in the future, we could pick a different parser based >>> on the request >>> >>> I need to plug some code which will parse request and add additional >>> stuff iinto req.context. I'd be happy to contribute it, but want to know >>> what was an intention. >>> >>> Thanks in advance >>> >>> -- >>> Sincerely yours >>> Mikhail Khludnev >>> Lucid Certified >>> Apache Lucene/Solr Developer >>> Grid Dynamics >>> >>> >>> >>> >>> >> > > > -- > Sincerely yours > Mikhail Khludnev > Lucid Certified > Apache Lucene/Solr Developer > Grid Dynamics > > > > > --14dae939965dc20de704b9bcb0cb Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I don't recall exactly... but I think it was just an open suggestion th= at we *could* use a different parser. =A0

Since that com= ment was added (5 years ago?) i don't think it has come up... =A0but if= there is a good use case (and a patch) it may still be a good idea =A0


On Fri, Feb 24, 201= 2 at 12:03 PM, Mikhail Khludnev <mkhludnev@griddynamics.com> wrote:
Ryan,

I did it too, but j= ust for curious, what was the idea of "pick a different parser based o= n request"?


On Fri, Feb 24, 2012 a= t 11:06 PM, Ryan McKinley <ryantxu@gmail.com> wrote:
I don't know exactly what you are trying= to do... but you *may* be able to do it by overriding=A0SolrDispatchFilter= #execute(...)

In my app, we add authentication tokens to the request conte= xt there.



On Fri, F= eb 24, 2012 at 7:49 AM, Mikhail Khludnev <mkhludnev@griddynamics.= com> wrote:
Hello,


line=A0
<= td style=3D"vertical-align:top;border-right-width:1px;background-color:rgb(= 238,238,238);color:rgb(80,80,80);text-align:right;border-right-style:solid;= border-right-color:rgb(80,80,80);padding-top:1px;padding-right:5px;padding-= bottom:1px;padding-left:5px"> 97
// I don't see a need to have this publicly configured just yet
and=A0
<= td style=3D"vertical-align:top;border-right-width:1px;background-color:rgb(= 238,238,238);color:rgb(80,80,80);text-align:right;border-right-style:solid;= border-right-color:rgb(80,80,80);padding-top:1px;padding-right:5px;padding-= bottom:1px;padding-left:5px"> 111
// TODO -- in the future, we could pick a different parser based on the= request

I need = to plug some code which will parse request and add additional stuff iinto r= eq.context. I'd be happy to contribute it, but want to know what was an= intention.=A0

Thanks in advance

--
Sincerely yours
Mikhail Khludnev
Lucid Certified<= div>Apache Lucene/Solr Developer
Grid Dynamics







--
= Sincerely yours
Mikhail Khludnev
Lucid Certified
Apache Lucene/So= lr Developer
Grid Dynamics




--14dae939965dc20de704b9bcb0cb--